Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] IA3 #1373

Merged
merged 5 commits into from
Feb 7, 2024
Merged

[docs] IA3 #1373

merged 5 commits into from
Feb 7, 2024

Conversation

stevhliu
Copy link
Member

Adds a guide for IA3 to the docs. The IA3Config is pretty barebones so feel free to suggest any improvements to it!

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

younesbelkada
younesbelkada approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@stevhliu
Copy link
Member Author

Thanks! I'll wait for one more review from @BenjaminBossan when he returns from vacation before merging!

pacman100
pacman100 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stevhliu for adding a task guide on IA3 method! 🔥🚀✨

Left a few suggestions/comments.

docs/source/task_guides/ia3.md Outdated Show resolved Hide resolved
docs/source/task_guides/ia3.md Outdated Show resolved Hide resolved
docs/source/task_guides/ia3.md Outdated Show resolved Hide resolved
BenjaminBossan
BenjaminBossan requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding the IA³ guide. Overall, it looks good. I would suggest to add just a couple of more lines of code to make it so that users can just copy and paste the code and it runs. WDYT?

docs/source/task_guides/ia3.md Show resolved Hide resolved
docs/source/task_guides/ia3.md Show resolved Hide resolved
docs/source/task_guides/ia3.md Outdated Show resolved Hide resolved
docs/source/task_guides/ia3.md Show resolved Hide resolved
docs/source/task_guides/ia3.md Outdated Show resolved Hide resolved
docs/source/task_guides/ia3.md Outdated Show resolved Hide resolved
BenjaminBossan
BenjaminBossan approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments quickly. LGTM.

@stevhliu stevhliu merged commit eba4595 into huggingface:main Feb 7, 2024
14 checks passed
@stevhliu stevhliu deleted the ia3 branch February 7, 2024 19:49
BenjaminBossan pushed a commit to BenjaminBossan/peft that referenced this pull request Mar 14, 2024
@stevhliu @BenjaminBossan
[docs] IA3 (huggingface#1373)
5fc3e10 
* first draft

* add to toctree

* feedback

* feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

@pacman100 pacman100 pacman100 approved these changes

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevhliu @HuggingFaceDocBuilderDev @BenjaminBossan @pacman100 @younesbelkada