Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deberta v1 support #221

Conversation

sam-h-bean
Copy link
Contributor

Add DeBERTa V1 support since huggingface/transformers#17617 now supports both

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sam-h-bean
Copy link
Contributor Author

@JingyaHuang want to merge this into your branch so both deberta and deberta-v2 get optimum support?

@JingyaHuang
Copy link
Contributor

Hi @sam-h-bean, the PRs only concern the ORTOptimizer but not the ORTQuantizer, so if you want to try quantization features, pls go ahead.

We are working on a bug in the doc builder, unfortunately, we can't merge this before all checks pass.

@sam-h-bean
Copy link
Contributor Author

Hi @sam-h-bean, the PRs only concern the ORTOptimizer but not the ORTQuantizer, so if you want to try quantization features, pls go ahead.

We are working on a bug in the doc builder, unfortunately, we can't merge this before all checks pass.

@JingyaHuang All checks have passed!

Copy link
Contributor

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +137 to +138
.idea
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is irrelevant to the PRs, I don't recommend adding .idea.

@JingyaHuang JingyaHuang deleted the branch huggingface:add-debertav2-optimization June 23, 2022 16:31
@JingyaHuang
Copy link
Contributor

Closed this as the supports for DeBERTa and DeBERTa-V2 have been added and merged in my previous PR. Thanks again for the contribution, excellent job!

@sam-h-bean sam-h-bean deleted the mrbean/add-debertav1-optimization branch June 23, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants