🐛 Fix model kwargs handling in pipeline function #2096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes how model-specific arguments are handled in the
pipeline()
function by replacing the problematic*model_kwargs
positional argument with a propermodel_kwargs
keyword argument.Changes
*model_kwargs
tomodel_kwargs: Optional[Dict[str, Any]] = None
model_kwargs
is NoneWhy?
The previous implementation using
*model_kwargs
as positional arguments could silently drop model-specific arguments, leading to unexpected behavior. This change ensures model arguments are properly passed through and provides better type safety and API clarity.