Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix model kwargs handling in pipeline function #2096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tal7aouy
Copy link

Fixes how model-specific arguments are handled in the pipeline() function by replacing the problematic *model_kwargs positional argument with a proper model_kwargs keyword argument.

  • Bug
  • Feature

Changes

  • Changed *model_kwargs to model_kwargs: Optional[Dict[str, Any]] = None
  • Added initialization of empty dict when model_kwargs is None
  • Properly forwarded model kwargs to loading functions

Why?

The previous implementation using *model_kwargs as positional arguments could silently drop model-specific arguments, leading to unexpected behavior. This change ensures model arguments are properly passed through and provides better type safety and API clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant