-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detr bettertransformer #1424
Open
issamarabi
wants to merge
9
commits into
huggingface:main
Choose a base branch
from
issamarabi:detr-bettertransformer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Detr bettertransformer #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Issam Arabi <[email protected]>
Signed-off-by: Issam Arabi <[email protected]>
- Converted DetrEncoderLayer weights to BetterTransformer format. - Added forward method for inference with BetterTransformer. - Added validation to ensure proper conversion. Signed-off-by: Issam Arabi <[email protected]>
Signed-off-by: Issam Arabi <[email protected]>
Signed-off-by: Issam Arabi <[email protected]>
Signed-off-by: Issam Arabi <[email protected]>
fxmarty
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the addition, looks fine to me! Let's just check that tests pass.
issamarabi
force-pushed
the
detr-bettertransformer
branch
from
October 7, 2023 14:46
a2ab86d
to
4180f3d
Compare
@issamarabi Thank you! Can you add Line 26 in c8cf353
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #488 and huggingface/transformers#20372
Added BetterTransformer support for DERT architecture.
Added test model for DERT model.
Before submitting