Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenVINO] Set Left Padding For Text Generation Task #839

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

apaniukov
Copy link
Contributor

What does this PR do?

Set the left padding side during tokenizer conversion for text generation tasks.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil
Copy link
Member

can you also run the code styling

@apaniukov
Copy link
Contributor Author

apaniukov commented Aug 14, 2024

can you also run the code styling

Done

Delete an import in pipeline_base.py to fix this issue:

ruff check . --fix
optimum/intel/pipelines/pipeline_base.py:298:54: F811 Redefinition of unused `PreTrainedTokenizerFast` from line 32
Found 1 error.

@IlyasMoutawwakil IlyasMoutawwakil merged commit 8cf3f26 into huggingface:main Aug 16, 2024
15 of 17 checks passed
IlyasMoutawwakil added a commit that referenced this pull request Aug 16, 2024
* Set Left Padding For Text Gen Task

* Make Style

* Add OV Tokenizers Version Check

* Update tests/openvino/test_exporters_cli.py

Co-authored-by: Ilyas Moutawwakil <[email protected]>

* Make Style

* Make Style

---------

Co-authored-by: Ilyas Moutawwakil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants