-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenVINO] Set Left Padding For Text Generation Task #839
Merged
IlyasMoutawwakil
merged 7 commits into
huggingface:main
from
apaniukov:task-to-padding-side
Aug 16, 2024
Merged
[OpenVINO] Set Left Padding For Text Generation Task #839
IlyasMoutawwakil
merged 7 commits into
huggingface:main
from
apaniukov:task-to-padding-side
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
AlexKoff88
reviewed
Aug 14, 2024
can you also run the code styling |
Co-authored-by: Ilyas Moutawwakil <[email protected]>
Done Delete an import in ruff check . --fix
optimum/intel/pipelines/pipeline_base.py:298:54: F811 Redefinition of unused `PreTrainedTokenizerFast` from line 32
Found 1 error. |
IlyasMoutawwakil
approved these changes
Aug 15, 2024
AlexKoff88
approved these changes
Aug 15, 2024
IlyasMoutawwakil
added a commit
that referenced
this pull request
Aug 16, 2024
* Set Left Padding For Text Gen Task * Make Style * Add OV Tokenizers Version Check * Update tests/openvino/test_exporters_cli.py Co-authored-by: Ilyas Moutawwakil <[email protected]> * Make Style * Make Style --------- Co-authored-by: Ilyas Moutawwakil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Set the left padding side during tokenizer conversion for text generation tasks.
Fixes # (issue)
Before submitting