Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate OH CLIP (roberta-clip) training to torch.compile #1507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chaojun-zhang
Copy link

Change-Id: I466309e0cd8ad151897fcc207f4f52296a2db5c4

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Change-Id: I466309e0cd8ad151897fcc207f4f52296a2db5c4
@chaojun-zhang chaojun-zhang changed the title [SW-179940] Migrate OH CLIP (roberta-clip) training to torch.compile Migrate OH CLIP (roberta-clip) training to torch.compile Nov 21, 2024
@astachowiczhabana
Copy link
Contributor

@libinta this commit is required with next OH release

@vidyasiv
Copy link
Contributor

@chaojun-zhang , please paste output of modified commands here run w/ latest 1.19 docker. I am queued up but not been able to get a 8hpu G2 host far.

Copy link
Contributor

@vidyasiv vidyasiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chaojun-zhang can you also ensure the command line options provide optimal performance for torch compile mode with the respective models?

@jiminha jiminha added the run-test Run CI for PRs from external contributors label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-test Run CI for PRs from external contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants