Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback to pyyaml #390

Merged
merged 2 commits into from
Oct 6, 2021
Merged

rollback to pyyaml #390

merged 2 commits into from
Oct 6, 2021

Conversation

elishowk
Copy link
Contributor

@elishowk elishowk commented Oct 6, 2021

Following #355
And discussion about ruamel.yaml not being supported in Windows builds

Since YAML spec 1.2 is planned for pyyaml 6.1 yaml/pyyaml#555, we here drop support for not parsing values no (and other non-quoted strings) to boolean.

@elishowk elishowk self-assigned this Oct 6, 2021
@LysandreJik
Copy link
Member

Thank you, @elishowk! Do you mind running the code quality script?

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge after fixing the code quality issues

@elishowk elishowk merged commit dc53a66 into main Oct 6, 2021
@elishowk elishowk deleted the restore-pyyaml branch October 6, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants