Tag repos using HFSummaryWriter with 'hf-summary-writer'
#2398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
severo
reviewed
Jul 18, 2024
| except EntryNotFoundError: | ||
| card = ModelCard("") | ||
| tags = card.data.get("tags", []) | ||
| tags.append("hf-summary-writer") |
There was a problem hiding this comment.
Shouldn't we check if the tag already exists?
There was a problem hiding this comment.
Definitely! Otherwise we would end up with 10 times the same tag if running a lot of experiments ^^
Addressed in c05857d
severo
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following recent discussions with @severo. This PR:
hf-summary-writerto the model card metadata when usingHFSummaryWriter(will help with discoverability/analytics)See https://huggingface.co/spaces/severo/training-metrics-tab/discussions/1.