Fix ModelHubMixin when class is a dataclass #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
Mar 26, 2024
|
Thanks for the review @LysandreJik. Will merge and make a patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ModelHubMixin class happens to be a dataclass,
__init__method will accept**kwargswheninspecting it. However, due to how dataclasses work, we cannot forward arbitrary kwargs to the
__init__.This test ensures that the
from_pretrainedmethod does not raise an error when the class is a dataclass.This PR fixes the SetFit integration (see #2157). However, this is not a pattern we want to promote. Dataclasses are meant to store data. Model classes are more complex and doesn't play well with internal values.