Request Persistent Storage #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Wauplin
reviewed
Jul 26, 2023
There was a problem hiding this comment.
Really nice and clean implementation @freddyaboulton, thanks a lot!
I left a few minor comments but overall looks very clean. For the tests, I would just mock them as it is done for request_space_hardware (see here).
Also, could you add a section in the Manage your Space guide? (here). Thanks in advance!
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
freddyaboulton
force-pushed
the
1553-persistent-storage
branch
from
708110b
to
440cda8
Compare
|
Thanks for the feedback @Wauplin ! I addressed your comments and added some unit tests + section to the guide. |
Wauplin
approved these changes
Jul 26, 2023
|
I have to fix the bugs in the CI but they are unrelated from your PR so it can be merged now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1553
Will write unit tests tomorrow.