-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple class to ease saving loading from HF hub #9
Comments
Sounds like a great feature! Not sure about calling Maybe Finally, not sure about implementing as a mixin vs. subclassing |
I'm fine with adding a |
@patrickvonplaten this is |
My bad! Then I think it's a good idea to have a |
Okay. I will start PR then. |
I agree with @julien-c and @patrickvonplaten on the fact it should be a mixin. Seems like a useful feature, so thanks for tackling this @vasudevgupta7 ! |
…sed in issue #9). (#11) * work initiated * start upload_to_hub * add changes * final-push * i feel this is better. * updated for Repositary class * small updates * fix mutiple calling * small fix * make style * add everything * minor fix * minor fix * done evrything * small fix * [doc] remove mention of TF support * Fix typings (i think) * We do NOT want to have a hard requirement on torch * Fix flake8 * Fix CI Co-authored-by: Julien Chaumond <[email protected]>
Would like to have a class from which model class can be inherited to add support of Huggingface hub. It will look something like this :
I can make a PR for adding this simple feature if you approve it.
The text was updated successfully, but these errors were encountered: