Don't write the ref file unless necessary (#2657)

* Don't write the ref file unless necessary * Add exception handling when dealing with ref file * Update src/huggingface_hub/_snapshot_download.py Co-authored-by: Lucain <[email protected]> * Update src/huggingface_hub/_snapshot_download.py --------- Co-authored-by: Lucain <[email protected]> Co-authored-by: Lucain <[email protected]>
huggingface · Nov 14, 2024 · d30853b · d30853b
1 parent 9e7ff04
commit d30853b
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/huggingface_hub/_snapshot_download.py b/src/huggingface_hub/_snapshot_download.py
@@ -256,9 +256,12 @@ def snapshot_download(
     # In that case store a ref.
     if revision != commit_hash:
         ref_path = os.path.join(storage_folder, "refs", revision)
-        os.makedirs(os.path.dirname(ref_path), exist_ok=True)
-        with open(ref_path, "w") as f:
-            f.write(commit_hash)
+        try:
+            os.makedirs(os.path.dirname(ref_path), exist_ok=True)
+            with open(ref_path, "w") as f:
+                f.write(commit_hash)
+        except OSError as e:
+            logger.warning(f"Ignored error while writing commit hash to {ref_path}: {e}.")
 
     # we pass the commit_hash to hf_hub_download
     # so no network call happens if we already