Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Célina <[email protected]>
  • Loading branch information
Wauplin and hanouticelina authored Nov 27, 2024
1 parent 53329b4 commit c3ee1da
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 9 deletions.
3 changes: 1 addition & 2 deletions src/huggingface_hub/_commit_scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ class CommitScheduler:
revision (`str`, *optional*):
The revision of the repo to commit to. Defaults to `main`.
private (`bool`, *optional*):
Whether to make the repo private. If `None` (default), will default to been public except if
the organization's default is private. This value is ignored if the repo already exist.
Whether to make the repo private. If `None` (default), the repo will be public unless the organization's default is private. This value is ignored if the repo already exists.
token (`str`, *optional*):
The token to use to commit to the repo. Defaults to the token saved on the machine.
allow_patterns (`List[str]` or `str`, *optional*):
Expand Down
3 changes: 1 addition & 2 deletions src/huggingface_hub/_tensorboard_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ class HFSummaryWriter(SummaryWriter):
repo_revision (`str`, *optional*):
The revision of the repo to which the logs will be pushed. Defaults to "main".
repo_private (`bool`, *optional*):
Whether to create a private repo or not. If `None` (default), will default to been public except if
the organization's default is private. This argument is ignored if the repo already exists.
Whether to make the repo private. If `None` (default), the repo will be public unless the organization's default is private. This value is ignored if the repo already exists.
path_in_repo (`str`, *optional*):
The path to the folder in the repo where the logs will be pushed. Defaults to "tensorboard/".
repo_allow_patterns (`List[str]` or `str`, *optional*):
Expand Down
5 changes: 2 additions & 3 deletions src/huggingface_hub/hf_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -3462,8 +3462,7 @@ def create_repo(
https://huggingface.co/docs/huggingface_hub/quick-start#authentication).
To disable authentication, pass `False`.
private (`bool`, *optional*):
Whether the model repo should be private. If `None` (default), will default to been public except if
the organization's default is private.
Whether to make the repo private. If `None` (default), the repo will be public unless the organization's default is private. This value is ignored if the repo already exists.
repo_type (`str`, *optional*):
Set to `"dataset"` or `"space"` if uploading to a dataset or
space, `None` or `"model"` if uploading to a model. Default is
Expand Down Expand Up @@ -5049,7 +5048,7 @@ def upload_large_folder(
The branch to commit to. If not provided, the `main` branch will be used.
private (`bool`, `optional`):
Whether the repository should be private.
If `None` (default), will default to been public except if the organization's default is private.
If `None` (default), the repo will be public unless the organization's default is private.
allow_patterns (`List[str]` or `str`, *optional*):
If provided, only files matching at least one pattern are uploaded.
ignore_patterns (`List[str]` or `str`, *optional*):
Expand Down
2 changes: 1 addition & 1 deletion src/huggingface_hub/hub_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ def push_to_hub(
Message to commit while pushing.
private (`bool`, *optional*):
Whether the repository created should be private.
If `None` (default), will default to been public except if the organization's default is private.
If `None` (default), the repo will be public unless the organization's default is private.
token (`str`, *optional*):
The token to use as HTTP bearer authorization for remote files. By default, it will use the token
cached when running `huggingface-cli login`.
Expand Down
2 changes: 1 addition & 1 deletion src/huggingface_hub/keras_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ def push_to_hub_keras(
Message to commit while pushing.
private (`bool`, *optional*):
Whether the repository created should be private.
If `None` (default), will default to been public except if the organization's default is private.
If `None` (default), the repo will be public unless the organization's default is private.
api_endpoint (`str`, *optional*):
The API endpoint to use when pushing the model to the hub.
token (`str`, *optional*):
Expand Down

0 comments on commit c3ee1da

Please sign in to comment.