Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox Memory leak and Inversion Fix #80

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

TravisThomp
Copy link
Contributor


About The Memory Leak

The inversion was caused by the memory leak, not from the sort worker lagging behind.
The memory leak was due to rapid recreation of the sortData arrays each time the splatData was changed.

Assuming this was caused by FireFox mishandling Garbage Collection in Workers.

Although the inversion might happen with massive splat movement still, there is no getting around cpu depth sorting with webgl2 (learned that the hard way... can't wait for webgpu!).

Copy link
Collaborator

@dylanebert dylanebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dylanebert dylanebert merged commit 9bdccf4 into huggingface:main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model Inverstion and Distortion during Rotation (on Firefox browsers)
2 participants