Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos, improve, update at main-page files and .github files #5588

Merged
merged 22 commits into from
Nov 14, 2023
Merged

Fix typos, improve, update at main-page files and .github files #5588

merged 22 commits into from
Nov 14, 2023

Conversation

tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Oct 30, 2023

What does this PR do?

Hi! Thank you for this awesome library!
I am new to open source. Firstly, I am reading the documentation. Secondly, I will read the codebase. Thirdly, I plan to make documentation and code contributions.
I would be grateful for your feedback. @stevhliu @yiyixuxu @patrickvonplaten

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 30, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@DN6
Copy link
Collaborator

DN6 commented Oct 31, 2023

cc'ing: @stevhliu as well.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for reviewing even the setup files for typos 🙂

.github/ISSUE_TEMPLATE/translate.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/translate.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Show resolved Hide resolved
CITATION.cff Show resolved Hide resolved
PHILOSOPHY.md Outdated Show resolved Hide resolved
PHILOSOPHY.md Outdated Show resolved Hide resolved
PHILOSOPHY.md Outdated Show resolved Hide resolved
PHILOSOPHY.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@patrickvonplaten
Copy link
Contributor

Feel free to merge once you're happy with the PR @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more changes and we should be good to merge :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
PHILOSOPHY.md Outdated Show resolved Hide resolved
PHILOSOPHY.md Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
tolgacangoz and others added 3 commits November 4, 2023 15:43
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
@stevhliu
Copy link
Member

stevhliu commented Nov 8, 2023

Feel free to ping me for another review after you've addressed all the feedback @StandardAI! 🤗

@tolgacangoz
Copy link
Contributor Author

tolgacangoz commented Nov 8, 2023

@stevhliu
I should have reviewed the "Pending" comments 😔. I didn't know that.

@tolgacangoz tolgacangoz requested a review from stevhliu November 8, 2023 16:00
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating and improving this PR!

@stevhliu stevhliu merged commit 3b37488 into huggingface:main Nov 14, 2023
13 checks passed
@tolgacangoz
Copy link
Contributor Author

Thanks for iterating and improving this PR!

Thanks for your feedback!

@tolgacangoz tolgacangoz deleted the fix-typos-5 branch November 25, 2023 11:40
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
…ingface#5588)

* Update keywords; remove version cuz it changes constantly?

* Update if necessary

* Fix typos and links

* version_range_max from PyTorch's setup.py; fix typos; 1 checklist is enough?

* Fix a typo

* Fix typos

* There is already a Blank issue link at the bottom of the page; direct to Diffusers' forum

* Add 🌐 Translating a New Language? page

* Update .github/ISSUE_TEMPLATE/translate.md

Co-authored-by: Steven Liu <[email protected]>

* Update PHILOSOPHY.md

Co-authored-by: Steven Liu <[email protected]>

* Update PHILOSOPHY.md

Co-authored-by: Steven Liu <[email protected]>

* Update PHILOSOPHY.md

* Update PHILOSOPHY.md

* Update CONTRIBUTING.md

Co-authored-by: Steven Liu <[email protected]>

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

Co-authored-by: Steven Liu <[email protected]>

* Update PHILOSOPHY.md

Co-authored-by: Steven Liu <[email protected]>

* Update PHILOSOPHY.md

Co-authored-by: Steven Liu <[email protected]>

* Update README.md

Co-authored-by: Steven Liu <[email protected]>

* Add X account link

* Update setup.py

* Update CITATION.cff

---------

Co-authored-by: Steven Liu <[email protected]>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…ingface#5588)

* Update keywords; remove version cuz it changes constantly?

* Update if necessary

* Fix typos and links

* version_range_max from PyTorch's setup.py; fix typos; 1 checklist is enough?

* Fix a typo

* Fix typos

* There is already a Blank issue link at the bottom of the page; direct to Diffusers' forum

* Add 🌐 Translating a New Language? page

* Update .github/ISSUE_TEMPLATE/translate.md

Co-authored-by: Steven Liu <[email protected]>

* Update PHILOSOPHY.md

Co-authored-by: Steven Liu <[email protected]>

* Update PHILOSOPHY.md

Co-authored-by: Steven Liu <[email protected]>

* Update PHILOSOPHY.md

* Update PHILOSOPHY.md

* Update CONTRIBUTING.md

Co-authored-by: Steven Liu <[email protected]>

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

Co-authored-by: Steven Liu <[email protected]>

* Update PHILOSOPHY.md

Co-authored-by: Steven Liu <[email protected]>

* Update PHILOSOPHY.md

Co-authored-by: Steven Liu <[email protected]>

* Update README.md

Co-authored-by: Steven Liu <[email protected]>

* Add X account link

* Update setup.py

* Update CITATION.cff

---------

Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants