-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos, improve, update at main-page files and .github files #5588
Conversation
… to Diffusers' forum
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽
cc'ing: @stevhliu as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for reviewing even the setup files for typos 🙂
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Feel free to merge once you're happy with the PR @stevhliu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more changes and we should be good to merge :)
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Co-authored-by: Steven Liu <[email protected]>
Feel free to ping me for another review after you've addressed all the feedback @StandardAI! 🤗 |
@stevhliu |
Co-authored-by: Steven Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating and improving this PR!
Thanks for your feedback! |
…ingface#5588) * Update keywords; remove version cuz it changes constantly? * Update if necessary * Fix typos and links * version_range_max from PyTorch's setup.py; fix typos; 1 checklist is enough? * Fix a typo * Fix typos * There is already a Blank issue link at the bottom of the page; direct to Diffusers' forum * Add 🌐 Translating a New Language? page * Update .github/ISSUE_TEMPLATE/translate.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md * Update PHILOSOPHY.md * Update CONTRIBUTING.md Co-authored-by: Steven Liu <[email protected]> * Update CONTRIBUTING.md * Update CONTRIBUTING.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update README.md Co-authored-by: Steven Liu <[email protected]> * Add X account link * Update setup.py * Update CITATION.cff --------- Co-authored-by: Steven Liu <[email protected]>
…ingface#5588) * Update keywords; remove version cuz it changes constantly? * Update if necessary * Fix typos and links * version_range_max from PyTorch's setup.py; fix typos; 1 checklist is enough? * Fix a typo * Fix typos * There is already a Blank issue link at the bottom of the page; direct to Diffusers' forum * Add 🌐 Translating a New Language? page * Update .github/ISSUE_TEMPLATE/translate.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md * Update PHILOSOPHY.md * Update CONTRIBUTING.md Co-authored-by: Steven Liu <[email protected]> * Update CONTRIBUTING.md * Update CONTRIBUTING.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update PHILOSOPHY.md Co-authored-by: Steven Liu <[email protected]> * Update README.md Co-authored-by: Steven Liu <[email protected]> * Add X account link * Update setup.py * Update CITATION.cff --------- Co-authored-by: Steven Liu <[email protected]>
What does this PR do?
Hi! Thank you for this awesome library!
I am new to open source. Firstly, I am reading the documentation. Secondly, I will read the codebase. Thirdly, I plan to make documentation and code contributions.
I would be grateful for your feedback. @stevhliu @yiyixuxu @patrickvonplaten
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.