[Lora] correct lora saving & loading #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -265,15 +262,6 @@ def save_function(weights, filename): | |||
| # Save the model | |||
| state_dict = model_to_save.state_dict() | |||
|
|
|||
| # Clean the folder from a previous save | |||
There was a problem hiding this comment.
this was a bad copy-paste and is not needed
|
The documentation is not available anymore as the PR was closed or merged. |
|
The following code now works without problems: from diffusers import StableDiffusionPipeline
import torch
pipe = StableDiffusionPipeline.from_pretrained("runwayml/stable-diffusion-v1-5", torch_dtype=torch.float16)
pipe.unet.load_attn_procs("PhanAnh/sd-model-finetuned-lora", weight_name="pytorch_model.bin")
pipe.unet.save_attn_procs("./temp")
pipe.unet.load_attn_procs("./temp")
pipe.unet.save_attn_procs("./temp", safe_serialization=True)
pipe.unet.load_attn_procs("./temp")
pipe.unet.save_attn_procs("./temp", weight_name="lora.bin")
pipe.unet.load_attn_procs("./temp", weight_name="lora.bin")
pipe.unet.save_attn_procs("./temp", weight_name="lora.safetensors", safe_serialization=True)
pipe.unet.load_attn_procs("./temp", weight_name="lora.safetensors") |
sayakpaul
reviewed
Mar 14, 2023
Comment on lines
+153
to
+155
| if (is_safetensors_available() and weight_name is None) or ( | ||
| weight_name is not None and weight_name.endswith(".safetensors") | ||
| ): |
There was a problem hiding this comment.
Makes sense to add a small comment highlighting that we always look for safetensors first just for easy readability?
There was a problem hiding this comment.
Good point
sayakpaul
reviewed
Mar 14, 2023
src/diffusers/loaders.py
Outdated
| "`weights_name` is deprecated, please use `weight_name` instead.", | ||
| take_from=kwargs, | ||
| ) | ||
| print(weight_name) |
sayakpaul
approved these changes
Mar 14, 2023
w4ffl35
pushed a commit
to w4ffl35/diffusers
that referenced
this pull request
Apr 14, 2023
* [Lora] correct lora saving & loading * fix final * Apply suggestions from code review
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* [Lora] correct lora saving & loading * fix final * Apply suggestions from code review
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* [Lora] correct lora saving & loading * fix final * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should correct: #2616