Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix DatasetBuilder._split_generators incomplete type annotation #6799

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix DatasetBuilder._split_generators incomplete type annotation #6799

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61249f0
add `StreamingDownloadManager` to `DatasetBuilder._split_generators` …
JonasLoos Apr 10, 2024
d6a5e9a
Merge branch 'main' into main
mariosasko Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/datasets/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,7 +1446,7 @@ def _download_post_processing_resources(
return None

@abc.abstractmethod
def _split_generators(self, dl_manager: DownloadManager):
def _split_generators(self, dl_manager: Union[DownloadManager, StreamingDownloadManager]):
"""Specify feature dictionary generators and dataset splits.

This function returns a list of `SplitGenerator`s defining how to generate
Expand Down Expand Up @@ -1484,7 +1484,7 @@ def _split_generators(self, dl_manager: DownloadManager):
distribute the relevant parts to each split with the `gen_kwargs` argument

Args:
dl_manager (`DownloadManager`):
dl_manager (`Union[DownloadManager, StreamingDownloadManager]`):
Download manager to download the data

Returns:
Expand Down
Loading