Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if dataset features match before push in DatasetDict.push_to_hub #4372

Merged
merged 2 commits into from
May 20, 2022
Merged

Check if dataset features match before push in DatasetDict.push_to_hub #4372

merged 2 commits into from
May 20, 2022

Conversation

mariosasko
Copy link
Collaborator

Fix #4211

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 19, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

lhoestq
lhoestq approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks ! LGTM

@mariosasko mariosasko merged commit c2f0170 into master May 20, 2022
@mariosasko mariosasko deleted the fix-4211 branch May 20, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DatasetDict containing Datasets with different features when pushed to hub gets remapped features
3 participants
@mariosasko @HuggingFaceDocBuilderDev @lhoestq