Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PyArrow Version to 6 #4250

Merged
merged 5 commits into from
May 4, 2022

Conversation

dnaveenr
Copy link
Contributor

Fixes #4152

This PR updates the PyArrow version to 6 in setup.py, CI job files .circleci/config.yaml and .github/workflows/benchmarks.yaml files.
This will fix ArrayND error which exists in pyarrow 5.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 28, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks ! Can you also update the pyarrow version in .github/conda/meta.yaml ?

also cc @mariosasko @albertvillanova

setup.py Outdated Show resolved Hide resolved
@dnaveenr
Copy link
Contributor Author

dnaveenr commented May 3, 2022

Updated meta.yaml as well. Thanks.

@mariosasko
Copy link
Collaborator

I'm OK with bumping PyArrow to version 6 to match the version in Colab, but maybe a better solution would be to stop using extension types in our codebase to avoid similar issues.

@lhoestq
Copy link
Member

lhoestq commented May 4, 2022

but maybe a better solution would be to stop using extension types in our codebase to avoid similar issues.

I agree, not much attention has been payed to extension arrays in the latest developments of Arrow anyway.

Let's not use them more that what we do right now, and try to remove them at one point

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnaveenr !

@lhoestq lhoestq merged commit a069d71 into huggingface:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArrayND error in pyarrow 5
4 participants