Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip checksum computation in Imagefolder by default #4214

Merged
merged 7 commits into from
May 3, 2022
Merged

Skip checksum computation in Imagefolder by default #4214

merged 7 commits into from
May 3, 2022

Conversation

mariosasko
Copy link
Collaborator

Avoids having to set ignore_verifications=True in load_dataset("imagefolder", ...) to skip checksum verification and speed up loading.

The user can still pass DownloadConfig(record_checksums=True) to not skip this part.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 25, 2022 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

lhoestq
lhoestq reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! This will significantly speed up imagefolder :)

just one question about record_checksums:

src/datasets/utils/download_manager.py Outdated Show resolved Hide resolved
@mariosasko mariosasko requested a review from lhoestq May 2, 2022 16:06
lhoestq
lhoestq approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Feel free to merge when the CI is green :)

@mariosasko mariosasko merged commit 1f7f67a into master May 3, 2022
@mariosasko mariosasko deleted the imagefolder-skip-checksum-computation branch May 3, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariosasko @HuggingFaceDocBuilderDev @lhoestq