Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datasets task tags to align tags with models #4067

Merged
merged 12 commits into from
Apr 13, 2022

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Mar 30, 2022

Requires #4066 to be merged first

Following #4066 we need to update many dataset tags to use the new ones. This PR takes case of this and is quite big - feel free to review only certain tags if you don't want to spend too much time on it.

Note that the CI will never be green for this PR, because many dataset cards have missing tags or sections, and fixing them is out of scope of this PR (the CI on master will be green anyway)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 30, 2022

The documentation is not available anymore as the PR was closed or merged.

@lhoestq lhoestq marked this pull request as ready for review April 8, 2022 12:23
@mariosasko
Copy link
Collaborator

Looks good, but I think we are missing some scripts with outdated tags (RedCaps, MNIST, ...).

@lhoestq
Copy link
Member Author

lhoestq commented Apr 11, 2022

Just updated the tags of vision datasets :)
We can figure out one for image datasets without labels like PASS - not sure how to name the task for this, maybe image-fill-mask (for consistency with language modeling for pretraining) / masked-auto-encoding (from ViT). Let's see that in another PR later

Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should use multi-class image-classification as task_id for the updated vision datasets (beans, cats_vs_dogs, cifar10, cifar100) and not image-classification-other ....

datasets/svhn/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhoestq lhoestq merged commit edb4411 into master Apr 13, 2022
@lhoestq lhoestq deleted the tasks-alignment-with-models branch April 13, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants