Close PIL.Image file handler in Image.decode_example
#3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Quentin Lhoest <[email protected]>
|
The documentation is not available anymore as the PR was closed or merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the file handler of the PIL image object in
Image.decode_exampleto avoid theToo many open fileserror.To pass the image equality checks in CI,
Image.decode_examplecallsimage.load()regardless of how the image object is created (not only for thePIL.Image.open(local_path)case). This is needed becauseload()sets thereadonlyattribute of aPIL.Imageobject to 0 (it's 1 afterPIL.Image.open(file_like)), and in the older PIL versions (only fixed on main), that attribute is considered inPIL.Image.__eq__. More info can be found here: python-pillow/Pillow#5926.Fix #3985