Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flatten of Sequence feature type #3962

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Fix flatten of Sequence feature type #3962

merged 2 commits into from
Mar 21, 2022

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Mar 18, 2022

The Sequence features type is not correctly flattened if it contains a dictionary. This PR fixes this, and I added a test case for this.

Close #3795

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 18, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhoestq lhoestq merged commit 166f892 into master Mar 21, 2022
@lhoestq lhoestq deleted the fix-sequence-flatten branch March 21, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can not flatten natural_questions dataset
3 participants