Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cats_vs_dogs size #3878

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Update cats_vs_dogs size #3878

merged 1 commit into from
Mar 10, 2022

Conversation

mariosasko
Copy link
Collaborator

It seems like 12 new examples have been added to the cats_vs_dogs. This PR updates the size in the card and the info file to avoid a verification error (reported by @stevhliu).

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@lhoestq
Copy link
Member

lhoestq commented Mar 10, 2022

Maybe NonMatchingSplitsSizesError errors should also tell the user to try using a more recent version of the dataset to get the fixes ?

@mariosasko
Copy link
Collaborator Author

@lhoestq Good idea. Will open a new PR to improve the error messages of NonMatchingSplitsSizesError, NonMatchingChecksumsError, ...

@mariosasko mariosasko merged commit 8ddcb9d into master Mar 10, 2022
@mariosasko mariosasko deleted the update-cats_vs_dogs-size branch March 10, 2022 14:21
@murphyk
Copy link

murphyk commented Sep 29, 2022

It seems there is still a problem. I am using datasets version 2.5.1.
I just typed ds = load_dataset("cats_vs_dogs") and get the error below.

NonMatchingSplitsSizesError: [{'expected': SplitInfo(name='train', num_bytes=3893603, num_examples=23422, dataset_name='cats_vs_dogs'), 'recorded': SplitInfo(name='train', num_bytes=3891612, num_examples=23410, dataset_name='cats_vs_dogs')}]

It looks like the dataset still only has 23,410 examples....

@lhoestq lhoestq mentioned this pull request Sep 30, 2022
@lhoestq
Copy link
Member

lhoestq commented Sep 30, 2022

Thanks for reporting, I opened #5047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants