Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wikitablequestions dataset #3870

Merged
merged 10 commits into from
Mar 14, 2022
Merged

Conversation

SivilTaram
Copy link
Contributor

No description provided.

@SivilTaram
Copy link
Contributor Author

@lhoestq Would you mind reviewing it when you're available? Thanks!

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks for adding this dataset ! :)
The dataset script and dataset cards look pretty good

It looks like your dummy_data.zip files are quite big though (>1MB each), do you think we can reduce their sizes ? This way this git repository doesn't become too big

datasets/wikitablequestions/README.md Outdated Show resolved Hide resolved
datasets/wikitablequestions/wikitablequestions.py Outdated Show resolved Hide resolved
@SivilTaram
Copy link
Contributor Author

Awesome thanks for adding this dataset ! :) The dataset script and dataset cards look pretty good

It looks like your dummy_data.zip files are quite big though (>1MB each), do you think we can reduce their sizes ? This way this git repository doesn't become too big

I have manually reduced the dummy_data.zip and its current size is about 54KB. Hope it is fine for you!

@SivilTaram SivilTaram requested a review from lhoestq March 11, 2022 06:35
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot ! Since the dummy data files are still >50KB each, feel free to only keep the random-split-1 one - the others can be removed

I only have one final comment. Let me know when you're done with the dummy data and I think we can merge :)

datasets/wikitablequestions/wikitablequestions.py Outdated Show resolved Hide resolved
@SivilTaram SivilTaram requested a review from lhoestq March 13, 2022 00:55
@SivilTaram
Copy link
Contributor Author

@lhoestq I think the dataset is ready to merge now. Any follow-up question is welcome :-D

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! It looks all good now :)

@lhoestq lhoestq merged commit b2af98c into huggingface:master Mar 14, 2022
@SivilTaram
Copy link
Contributor Author

Thanks ! It looks all good now :)

Awesome! Thanks for your quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants