-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wikitablequestions dataset #3870
Conversation
@lhoestq Would you mind reviewing it when you're available? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks for adding this dataset ! :)
The dataset script and dataset cards look pretty good
It looks like your dummy_data.zip
files are quite big though (>1MB each), do you think we can reduce their sizes ? This way this git repository doesn't become too big
I have manually reduced the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot ! Since the dummy data files are still >50KB each, feel free to only keep the random-split-1
one - the others can be removed
I only have one final comment. Let me know when you're done with the dummy data and I think we can merge :)
@lhoestq I think the dataset is ready to merge now. Any follow-up question is welcome :-D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! It looks all good now :)
Awesome! Thanks for your quick response! |
No description provided.