Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ElkarHizketak v1.0 dataset #3780

Merged
merged 8 commits into from
Mar 4, 2022
Merged

Add ElkarHizketak v1.0 dataset #3780

merged 8 commits into from
Mar 4, 2022

Conversation

antxa
Copy link
Contributor

@antxa antxa commented Feb 23, 2022

No description provided.

lhoestq
lhoestq reviewed Feb 25, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! Thanks a lot for adding this dataset :) And good job with the dataset card and the dataset script

I added a few comments/suggestions:

datasets/elkarhizketak/README.md Show resolved Hide resolved
datasets/elkarhizketak/README.md Outdated Show resolved Hide resolved
datasets/elkarhizketak/README.md Outdated Show resolved Hide resolved
datasets/elkarhizketak/dummy/plain_text/1.0.0/dummy_data/elkarhizketak-dev-v1.0.json Outdated Show resolved Hide resolved
datasets/elkarhizketak/elkarhizketak.py Outdated Show resolved Hide resolved
lhoestq
lhoestq approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! It's all good now :)

I just fixed a tag and some code formatting:

datasets/elkarhizketak/README.md Outdated Show resolved Hide resolved
datasets/elkarhizketak/README.md Show resolved Hide resolved
datasets/elkarhizketak/elkarhizketak.py Outdated Show resolved Hide resolved
datasets/elkarhizketak/elkarhizketak.py Outdated Show resolved Hide resolved
datasets/elkarhizketak/elkarhizketak.py Outdated Show resolved Hide resolved
datasets/elkarhizketak/elkarhizketak.py Outdated Show resolved Hide resolved
datasets/elkarhizketak/elkarhizketak.py Outdated Show resolved Hide resolved
@lhoestq
Copy link
Member

lhoestq commented Mar 4, 2022

I also filled some missing sections in the dataset card

@lhoestq lhoestq merged commit cf47649 into huggingface:master Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antxa @lhoestq