Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added electricity load diagram dataset #3722

Merged
merged 11 commits into from
Feb 16, 2022

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Feb 15, 2022

Initial Electricity Load Diagram time series dataset.

Copy link
Collaborator

@mariosasko mariosasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @kashif! LGTM!

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! Good job with the dataset script and the dataset card. I especially like the example in the dataset card that says explicitly how users can change the configuration. This is going to be the very first time series dataset available !

Let us know if it's all good on your side, so we can merge this PR :)

Also are there some things you'd like to see improved in datasets in the future for time series data ?

@lhoestq lhoestq merged commit edc97be into huggingface:master Feb 16, 2022
@kashif kashif deleted the electricity-load-diagram branch February 16, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants