Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web_nlg metadata #2362

Closed
wants to merge 1 commit into from
Closed

Fix web_nlg metadata #2362

wants to merge 1 commit into from

Conversation

julien-c
Copy link
Member

Our metadata storage system does not support . inside keys. cc @Pierrci

@julien-c julien-c requested review from yjernite and lhoestq May 14, 2021 17:15
@lhoestq
Copy link
Member

lhoestq commented May 17, 2021

Hi ! release_v2.1 and the others are dataset configuration names.

The configuration names are used to show the right code snippet in the UI to load the dataset.
For example if the parsing of the web_nlg tags worked correctly we would have:
image

Therefore I don't think it's a good idea to rename the configurations from release_v2.1 to release_v2_1 as the code snippet would be wrong in this case.

Moreover we can't really disallow dots in configuration names and rename the configurations since it would be a big breaking change. It's commonly used, especially with multilingual datasets. For example load_dataset("indic_glue", "sna.bn").

Is this something that can be fixed on the moonlanding side instead ?

@julien-c
Copy link
Member Author

Is this something that can be fixed on the moonlanding side instead ?

Not really unless we change database:)

We'll maybe try to find another workaround, but super low-prio given that it's the only dataset that has those dotted keys in the YAML metadata

@lhoestq
Copy link
Member

lhoestq commented May 17, 2021

Ok, should we close this PR then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants