Add GGUF BF16 dtype support #2387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricLBuehler
commented
Aug 17, 2024
| @@ -409,6 +409,7 @@ impl QCudaStorage { | |||
| match self.dtype { | |||
| GgmlDType::F32 => deq::<f32>(&buffer, block_len, &mut out)?, | |||
| GgmlDType::F16 => deq::<half::f16>(&buffer, block_len, &mut out)?, | |||
| GgmlDType::BF16 => deq::<half::bf16>(&buffer, block_len, &mut out)?, | |||
There was a problem hiding this comment.
With #2424 this can be optimized!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
GgmlDTypeonly supports F16 and not BF16. This PR introduces support for the BF16 type.I would appreciate a check if this looks good! I have tested with success on my machine which has
avxandf16c, and the CUDA tests also pass even though no changes were necessary.I also noted that there will be a confusing situation in this case, though, if the tensor is part of a QMatMul. In this case (and for all other types not supported for quantized matmul in QStorage), we should perhaps dequantize and then perform the matmul using cublas? This modification could be made in
QStorage::fwd, perhaps.