Add AVG Pooling cpu implementation #2296
Open
+128
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WenheLI I think this is correct. |
|
@EricLBuehler - Thanks! I guess another question is that in the CPU backend implementation, we should be able to speed this up by using vectorization. Not sure in candle's codebase, do we already have some infrastructure that can help us? |
|
Hi @WenheLI, I think you could use something like Rayon, just replace the for loops (probably just choose one to replace as rayon uses the number of CPU cores as the number of threads by default) and replace |
|
Thanks! Added vectorization. Wondering if someone can I take a look and review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to resolve #2294