-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rpc framework based on sofa-rpc #1
Conversation
9fcd197
to
e8c37a3
Compare
|
||
@Override | ||
public <T> T serviceProxy(String interfaceId) { | ||
ConsumerConfig<T> config = this.consumerConfig(null, interfaceId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return serviceProxy(null, interfaceId) ?
this.serverConfig.setProtocol(conf.get(RpcOptions.RPC_PROTOCOL)) | ||
.setHost(conf.get(RpcOptions.RPC_SERVER_HOST)) | ||
.setPort(conf.get(RpcOptions.RPC_SERVER_PORT)) | ||
.setDaemon(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to listen on a random port? There are a few of workers on a computer, and they can't listen on same port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can use sofa optionserver.adaptive.port
, or 0 means random port.
seems there is bug using random port: sofastack/sofa-bolt#196 , and fixed bolt v1.6.1
e8c37a3
to
7d9ead9
Compare
Co-authored-by: Jermy Li <[email protected]> Co-authored-by: xuliguov5 <[email protected]>
7d9ead9
to
d81fab4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=========================================
Coverage ? 92.09%
Complexity ? 62
=========================================
Files ? 9
Lines ? 253
Branches ? 21
=========================================
Hits ? 233
Misses ? 10
Partials ? 10 Continue to review full report at Codecov.
|
d81fab4
to
741a129
Compare
ee27d40
to
ae2f4a0
Compare
e9a9009
to
a18e537
Compare
.travis.yml
Outdated
language: java | ||
|
||
jdk: | ||
- openjdk8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jdk:
- oraclejdk8
dist: trusty
…g log4j2.xml in tar
Co-authored-by: Jermy Li [email protected]
Co-authored-by: xuliguov5 [email protected]