Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rpc framework based on sofa-rpc #1

Merged
merged 10 commits into from
Mar 23, 2021
Merged

add rpc framework based on sofa-rpc #1

merged 10 commits into from
Mar 23, 2021

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Mar 17, 2021

Co-authored-by: Jermy Li [email protected]
Co-authored-by: xuliguov5 [email protected]

@javeme javeme force-pushed the add-rpc-framework branch from 9fcd197 to e8c37a3 Compare March 17, 2021 09:56

@Override
public <T> T serviceProxy(String interfaceId) {
ConsumerConfig<T> config = this.consumerConfig(null, interfaceId);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return serviceProxy(null, interfaceId) ?

this.serverConfig.setProtocol(conf.get(RpcOptions.RPC_PROTOCOL))
.setHost(conf.get(RpcOptions.RPC_SERVER_HOST))
.setPort(conf.get(RpcOptions.RPC_SERVER_PORT))
.setDaemon(false);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to listen on a random port? There are a few of workers on a computer, and they can't listen on same port.

Copy link
Contributor Author

@javeme javeme Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can use sofa optionserver.adaptive.port, or 0 means random port.

seems there is bug using random port: sofastack/sofa-bolt#196 , and fixed bolt v1.6.1

@javeme javeme force-pushed the add-rpc-framework branch from e8c37a3 to 7d9ead9 Compare March 17, 2021 10:13
@javeme javeme force-pushed the add-rpc-framework branch from 7d9ead9 to d81fab4 Compare March 18, 2021 06:21
@codecov-io
Copy link

codecov-io commented Mar 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@3914813). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   92.09%           
  Complexity        ?       62           
=========================================
  Files             ?        9           
  Lines             ?      253           
  Branches          ?       21           
=========================================
  Hits              ?      233           
  Misses            ?       10           
  Partials          ?       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3914813...999d81f. Read the comment docs.

@javeme javeme force-pushed the add-rpc-framework branch from d81fab4 to 741a129 Compare March 18, 2021 12:37
@javeme javeme force-pushed the add-rpc-framework branch from ee27d40 to ae2f4a0 Compare March 19, 2021 13:15
coderzc
coderzc previously approved these changes Mar 22, 2021
houzhizhen
houzhizhen previously approved these changes Mar 22, 2021
.travis.yml Outdated
language: java

jdk:
- openjdk8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jdk:

  • oraclejdk8

dist: trusty

@javeme javeme dismissed stale reviews from houzhizhen and coderzc via 99faaea March 22, 2021 12:50
Linary
Linary previously approved these changes Mar 22, 2021
coderzc
coderzc previously approved these changes Mar 22, 2021
@javeme javeme dismissed stale reviews from coderzc and Linary via 999d81f March 23, 2021 05:08
@zhoney zhoney merged commit 159143c into master Mar 23, 2021
@zhoney zhoney deleted the add-rpc-framework branch March 23, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants