Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement connection management, gremlin query, execute histroy and g… #3

Merged
merged 7 commits into from
Sep 4, 2019
Merged

Implement connection management, gremlin query, execute histroy and g… #3

merged 7 commits into from
Sep 4, 2019

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Aug 1, 2019

…remlin collection

javeme
javeme requested changes Aug 1, 2019
View reviewed changes
hubble-be/src/main/java/com/baidu/hugegraph/advisor/ExceptionAdvisor.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/advisor/ExceptionAdvisor.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/advisor/ExceptionAdvisor.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/advisor/MessageSourceHandler.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/advisor/ResponseAdvisor.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/controller/SettingController.java Outdated
@GetMapping("common")
public UserInfo common(@RequestParam(value = "lang",
defaultValue = "en_US")
String lang,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add RequestParam style

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what means?

hubble-be/src/main/java/com/baidu/hugegraph/entity/AdjacentQuery.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/service/GraphConnectionService.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/service/GremlinCollectionService.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/util/EntityUtil.java Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 1, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e3f9b33). Click here to learn what that means.
The diff coverage is 22.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   22.85%           
  Complexity        ?       79           
=========================================
  Files             ?       41           
  Lines             ?      840           
  Branches          ?      116           
=========================================
  Hits              ?      192           
  Misses            ?      623           
  Partials          ?       25
Impacted Files Coverage Δ Complexity Δ
...java/com/baidu/hugegraph/entity/GremlinResult.java 0% <0%> (ø) 0 <0> (?)
.../java/com/baidu/hugegraph/entity/GremlinQuery.java 0% <0%> (ø) 0 <0> (?)
.../com/baidu/hugegraph/entity/GremlinCollection.java 0% <0%> (ø) 0 <0> (?)
...m/baidu/hugegraph/exception/InternalException.java 0% <0%> (ø) 0 <0> (?)
...main/java/com/baidu/hugegraph/common/Constant.java 0% <0%> (ø) 0 <0> (?)
...ava/com/baidu/hugegraph/entity/ExecuteHistory.java 0% <0%> (ø) 0 <0> (?)
...ain/java/com/baidu/hugegraph/util/GremlinUtil.java 0% <0%> (ø) 0 <0> (?)
...du/hugegraph/exception/ParameterizedException.java 0% <0%> (ø) 0 <0> (?)
...m/baidu/hugegraph/exception/ExternalException.java 0% <0%> (ø) 0 <0> (?)
...main/java/com/baidu/hugegraph/entity/UserInfo.java 0% <0%> (ø) 0 <0> (?)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f9b33...86dfaad. Read the comment docs.

javeme
javeme reviewed Aug 5, 2019
View reviewed changes
LICENSE Outdated Show resolved Hide resolved
hubble-be/pom.xml Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/config/SwaggerConfig.java Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/service/GremlinQueryService.java Outdated Show resolved Hide resolved
@Linary Linary force-pushed the v1.1 branch 4 times, most recently from 3633960 to a3fb82c Compare August 9, 2019 08:12
@Linary Linary force-pushed the v1.1 branch 2 times, most recently from 3827b4f to 6310478 Compare August 15, 2019 08:24
javeme
javeme previously approved these changes Aug 16, 2019
View reviewed changes
zhoney
zhoney suggested changes Aug 19, 2019
View reviewed changes
hubble-be/pom.xml Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/HugeGraphHubble.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/advisor/ExceptionAdvisor.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/advisor/ExceptionAdvisor.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/controller/GremlinCollectionController.java
@RequestMapping("gremlin-collections")
public class GremlinCollectionController extends BaseController {

private static final String NAME_REGEX = "[A-Za-z0-9_]{1,50}";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not same as GRAPH_REGEX in GraphConnectionController

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prd doc required

hubble-be/src/main/java/com/baidu/hugegraph/options/HubbleOptions.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/options/HubbleOptions.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/service/GremlinQueryService.java Outdated Show resolved Hide resolved
hubble-be/src/main/java/com/baidu/hugegraph/util/EntityUtil.java Outdated Show resolved Hide resolved
hubble-be/src/main/resources/hugegraph-hubble.properties Outdated Show resolved Hide resolved
zhoney
zhoney previously approved these changes Aug 19, 2019
View reviewed changes
@zhoney zhoney merged commit 31355af into master Sep 4, 2019
@zhoney zhoney deleted the v1.1 branch September 4, 2019 07:58
OshotOkill added a commit to OshotOkill/hugegraph-hubble that referenced this pull request Jun 23, 2020
@OshotOkill
[hubble-fe] Sync from master hugegraph#3
ba21284
OshotOkill added a commit to OshotOkill/hugegraph-hubble that referenced this pull request Mar 12, 2021
@OshotOkill
[HugeGraph-Hubble-fe] temp hugegraph#3
e058707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoney zhoney zhoney approved these changes

@javeme javeme javeme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Linary @javeme @zhoney