Support data-import task manager #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… where there are standing
Crayonn
reviewed
Jul 28, 2020
| onClick: () => { | ||
| dataAnalyzeStore.setFavoritePopUp('editFavorite'); | ||
| dataAnalyzeStore.resetFavoriteRequestStatus('add'); | ||
| dataAnalyzeStore.resetFavoriteRequestStatus('edit'); |
There was a problem hiding this comment.
They are two different request status who are being used in different situtaion
| dataMapStore.setSelectedFileId( | ||
| Number(dataMapStore.fileMapInfos[0].id) | ||
| ); | ||
| dataMapStore.setSelectedFileInfo(); |
There was a problem hiding this comment.
这里直接用setSelectedFileInfo，会不会好点
There was a problem hiding this comment.
In early devs there were some scenarios that only set file ids. Since now the scenarios are gone I 'll remove one of two steps later.
Crayonn
approved these changes
Jul 29, 2020
Linary
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.