Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white list for graph connection ip and port #221

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Feb 26, 2020

No description provided.

@Linary Linary force-pushed the ip-port-white-list branch from 482dac3 to d491522 Compare February 26, 2020 08:34
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #221 into master will increase coverage by 0.18%.
The diff coverage is 25.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #221      +/-   ##
=========================================
+ Coverage    9.71%   9.89%   +0.18%     
=========================================
  Files          86      86              
  Lines        2842    2879      +37     
  Branches      382     389       +7     
=========================================
+ Hits          276     285       +9     
- Misses       2545    2568      +23     
- Partials       21      26       +5
Impacted Files Coverage Δ
...main/java/com/baidu/hugegraph/util/HubbleUtil.java 14.28% <100%> (+14.28%) ⬆️
...ava/com/baidu/hugegraph/options/HubbleOptions.java 78% <44.44%> (-18.88%) ⬇️
...ugegraph/controller/GraphConnectionController.java 2.65% <5%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 034960f...d491522. Read the comment docs.

zhoney
zhoney previously approved these changes Feb 27, 2020

public static final ConfigListOption<Integer> CONNECTION_PORT_WHITE_LIST =
new ConfigListOption<>(
"graph_connection.port.white_list",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

port_white_list

hubble-be/src/main/resources/hugegraph-hubble.properties Outdated Show resolved Hide resolved
@@ -20,7 +20,10 @@ graph-connection.name.unmatch-regex=Invalid connection name, valid name is up to
graph-connection.graph.unmatch-regex=Invalid connection graph, valid graph is up to 48 alpha-numeric characters and underscores and only letters are supported as first letter
graph-connection.graph.unexist=There is no graph with the name {0} on service {1}:{2}
graph-connection.host.unmatch-regex=Invalid connection host, valid host is ip address or alpha-numeric characters and some special symbol like: _!~*'()-.
graph-connection.host.unresolved=Unresolved host or ip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IP

hubble-be/src/main/resources/i18n/messages.properties Outdated Show resolved Hide resolved
@javeme javeme merged commit 4132d9f into master Feb 28, 2020
@javeme javeme deleted the ip-port-white-list branch February 28, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants