-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge HugeGraph-Hubble-fe v1.2.0 #218
Conversation
…remlin collection
…pulations are no longer needed
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
======================================
Coverage 9.71% 9.71%
======================================
Files 86 86
Lines 2842 2842
Branches 382 382
======================================
Hits 276 276
Misses 2545 2545
Partials 21 21 Continue to review full report at Codecov.
|
@@ -0,0 +1,5 @@ | |||
export function checkIfLocalNetworkOffline(error: any) { | |||
if (!error.response) { | |||
throw new Error('网络错误,请查看您的本地连接'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: use i18n instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No i18n support before v1.2.1 here, plan to add it in v1.3.0
@@ -0,0 +1,1403 @@ | |||
import { observable, action, flow, computed } from 'mobx'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metadataConfigsStore/edgeTypeStore.ts
prefer to rename metadata to schema
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name metadata
is heavily used in hubble-fe
(about 800+ places), rename them all could be fragile and it's not that necessary
@@ -0,0 +1,1236 @@ | |||
import { createContext } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataAnalyzeStore.ts -- Keep a consistent file naming style, such as capitalizing the first letter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the exact api name which React
exports
No description provided.