Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge HugeGraph-Hubble-fe v1.2.0 #218

Merged
merged 39 commits into from
Feb 26, 2020
Merged

Merge HugeGraph-Hubble-fe v1.2.0 #218

merged 39 commits into from
Feb 26, 2020

Conversation

OshotOkill
Copy link
Contributor

No description provided.

Linary and others added 30 commits February 14, 2020 02:01
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #218 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #218   +/-   ##
======================================
  Coverage    9.71%   9.71%           
======================================
  Files          86      86           
  Lines        2842    2842           
  Branches      382     382           
======================================
  Hits          276     276           
  Misses       2545    2545           
  Partials       21      21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd2ee0...9cd2ee0. Read the comment docs.

@@ -0,0 +1,5 @@
export function checkIfLocalNetworkOffline(error: any) {
if (!error.response) {
throw new Error('网络错误,请查看您的本地连接');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: use i18n instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No i18n support before v1.2.1 here, plan to add it in v1.3.0

@@ -0,0 +1,1403 @@
import { observable, action, flow, computed } from 'mobx';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadataConfigsStore/edgeTypeStore.ts
prefer to rename metadata to schema

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name metadata is heavily used in hubble-fe (about 800+ places), rename them all could be fragile and it's not that necessary

@@ -0,0 +1,1236 @@
import { createContext } from 'react';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dataAnalyzeStore.ts -- Keep a consistent file naming style, such as capitalizing the first letter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the exact api name which React exports

@OshotOkill OshotOkill requested a review from javeme February 25, 2020 02:42
@Linary Linary merged commit 034960f into hugegraph:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants