Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the mvn args for docker build, like: -P stage #4

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

aroundabout
Copy link
Collaborator

@aroundabout aroundabout commented Dec 13, 2023

Main change

In release/latest, I add the build-args for the build and push action, which can be use in the related dockerfile server/loader/hubble
In computer, I directly add the mvn args.
And I have built the server/loader/hubble/computer in my own repo: https://github.com/aroundabout/action_demo/actions
build computer action
build server action
build hubble action
build loader action

And I have tested server/loader/hubble.
The computer related images are not tested.

image

related PR for docker file

server: apache/incubator-hugegraph#2386
hubble/loader: apache/incubator-hugegraph-toolchain#556

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 13, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aroundabout
Copy link
Collaborator Author

I have only published the computer related images, but not tested them.
Is there any easy test case for testing the computer images?
The link for computer image in my own repo: https://hub.docker.com/repository/docker/dandelionivy/hugegraph-computer/general

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 13, 2023
@imbajin imbajin merged commit c9f0d8e into hugegraph:master Dec 13, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants