-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add LDLNucleationMicroForce with tests in surfing #159
Conversation
@lyyc199586 can you give me commit permission?
|
added |
content for file run.sh
|
I have finished debugging, now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I force pushed to your branch to clean up all the irrelevant commits.
Mostly looks good to me. My only real request: Create a common base class for the nucleation micro-force materials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments: See below.
Start to implement the variational case of the nucleation model, see #158 (comment).
Not test yet.