Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LDLNucleationMicroForce with tests in surfing #159

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

lyyc199586
Copy link
Contributor

Start to implement the variational case of the nucleation model, see #158 (comment).

Not test yet.

@BoZeng1997
Copy link
Contributor

BoZeng1997 commented Jan 31, 2024

@lyyc199586 can you give me commit permission?

remote: Permission to lyyc199586/raccoon.git denied to BoZeng1997.
fatal: unable to access 'https://github.com/lyyc199586/raccoon.git/': The requested URL returned error: 403

@lyyc199586
Copy link
Contributor Author

@lyyc199586 can you give me commit permission?

remote: Permission to lyyc199586/raccoon.git denied to BoZeng1997.
fatal: unable to access 'https://github.com/lyyc199586/raccoon.git/': The requested URL returned error: 403

added

@BoZeng1997
Copy link
Contributor

content for file run.sh

l=0.35
refine=3
filebase=nuc2024_l${l}h0.035
# rm -rf .jitcache/
nohup mpiexec -n 4 ~/projects/raccoon/raccoon-opt -i elasticity_ldl.i \
--color off --trap-fpe \
filebase=$filebase refine=$refine l=$l \
Executioner/fixed_point_rel_tol=1e-4 \
Executioner/fixed_point_abs_tol=1e-7 \
Executioner/end_time=0.3 \
> ${filebase}.out 2>&1 &

@lyyc199586 lyyc199586 changed the title add source and include files with tests in surfing add LDLNucleationMicroForce with tests in surfing Jan 31, 2024
@lyyc199586
Copy link
Contributor Author

I have finished debugging, now h_correction is a bool option @BoZeng1997

Copy link
Owner

@hugary1995 hugary1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I force pushed to your branch to clean up all the irrelevant commits.

Mostly looks good to me. My only real request: Create a common base class for the nucleation micro-force materials.

Copy link
Contributor Author

@lyyc199586 lyyc199586 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Copy link
Owner

@hugary1995 hugary1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments: See below.

@hugary1995 hugary1995 merged commit 202c2a7 into hugary1995:devel Apr 24, 2024
6 checks passed
@lyyc199586 lyyc199586 deleted the nucforce branch April 24, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants