-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a global valid method #168
Conversation
This is useful. 👍 and you have your unique documentation format. Please submit only your changes. 🍻 |
Better if you can add some test cases, else I can do it. |
Sure, I'll remove my documentation and add some test cases. |
thank you @lucax88x 🍻 |
is this unit test sufficient? I couldn't find the "validation" part |
This is fine, I can add the rest. one more thing, do you want to add the documentation about how to set global valid method? |
Shouldn't the API documentation also be a part of index.html page ?
|
I just removed the documentation, I understood you wanted to do it yourself, just tell me where to put it |
@Nazanin1369 It should be, API documentation html page is our next mission as we discussed in group last week (I think). 😄 |
Sorry @lucax88x You can add below this section Thanks 🍻 |
I didn't. I ment we have to also include it in our index.html and in the
|
Got u 😂
|
Oh! I though you mean we need a html structure page for API documentation. For now, we can just add a link in header to direct to API.md |
added documentation @huei90 :) |
|
||
### **Select a global validation method** `watch blur submit submit-only`** | ||
|
||
`validationProvider.setValidMethod('submit')` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should say more about this.
I need this section changes only.
We should keep the original documentation style
means we don't need ~~~~~~~~~ style.
Got it, I didn't notice this change! editor did this... |
fixed it! @huei90 |
Thanks @lucax88x Thanks again 🍻 |
@lucax88x I have add one more test case for this feature. @Nazanin1369 API document added in header. |
Great!
|
Possibility to define an unique validmethod for all the validators