Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a global valid method #168

Merged
merged 4 commits into from
Dec 15, 2015
Merged

Added a global valid method #168

merged 4 commits into from
Dec 15, 2015

Conversation

lucax88x
Copy link

Possibility to define an unique validmethod for all the validators

@hueitan
Copy link
Owner

hueitan commented Dec 12, 2015

This is useful. 👍

and you have your unique documentation format.

Please submit only your changes.

🍻

@hueitan
Copy link
Owner

hueitan commented Dec 14, 2015

Better if you can add some test cases, else I can do it.

@lucax88x
Copy link
Author

Sure, I'll remove my documentation and add some test cases.

@hueitan
Copy link
Owner

hueitan commented Dec 14, 2015

thank you @lucax88x 🍻

@lucax88x
Copy link
Author

is this unit test sufficient? I couldn't find the "validation" part

@hueitan
Copy link
Owner

hueitan commented Dec 14, 2015

This is fine, I can add the rest.

one more thing, do you want to add the documentation about how to set global valid method?

@Nazanin1369
Copy link
Collaborator

Shouldn't the API documentation also be a part of index.html page ?
On Dec 14, 2015 1:31 AM, "Huei Tan" [email protected] wrote:

This is fine, I can add the rest.

one more thing, do you want to add the documentation about how to set
global valid method?


Reply to this email directly or view it on GitHub
#168 (comment)
.

@lucax88x
Copy link
Author

I just removed the documentation, I understood you wanted to do it yourself, just tell me where to put it

@hueitan
Copy link
Owner

hueitan commented Dec 14, 2015

@Nazanin1369 It should be, API documentation html page is our next mission as we discussed in group last week (I think). 😄

@hueitan
Copy link
Owner

hueitan commented Dec 14, 2015

@Nazanin1369
Copy link
Collaborator

I didn't. I ment we have to also include it in our index.html and in the
header menu as "API documentation" to be consistent. Please have that in
mind also.
On Dec 14, 2015 1:34 AM, "Luca Trazzi" [email protected] wrote:

I just removed the documentation, I understood you wanted to do it
yourself, just tell me where to put it


Reply to this email directly or view it on GitHub
#168 (comment)
.

@Nazanin1369
Copy link
Collaborator

Got u 😂
On Dec 14, 2015 1:37 AM, "Nazanin De" [email protected] wrote:

I didn't. I ment we have to also include it in our index.html and in the
header menu as "API documentation" to be consistent. Please have that in
mind also.
On Dec 14, 2015 1:34 AM, "Luca Trazzi" [email protected] wrote:

I just removed the documentation, I understood you wanted to do it
yourself, just tell me where to put it


Reply to this email directly or view it on GitHub
#168 (comment)
.

@hueitan
Copy link
Owner

hueitan commented Dec 14, 2015

Oh! I though you mean we need a html structure page for API documentation. For now, we can just add a link in header to direct to API.md

@lucax88x
Copy link
Author

added documentation @huei90 :)


### **Select a global validation method** `watch blur submit submit-only`**

`validationProvider.setValidMethod('submit')`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should say more about this.
I need this section changes only.

We should keep the original documentation style

means we don't need ~~~~~~~~~ style.

@lucax88x
Copy link
Author

Got it, I didn't notice this change! editor did this...

@lucax88x
Copy link
Author

fixed it! @huei90

@hueitan
Copy link
Owner

hueitan commented Dec 15, 2015

Thanks @lucax88x
Well done. I'm going to merge now 👍

Thanks again 🍻

hueitan pushed a commit that referenced this pull request Dec 15, 2015
Added a global valid method
@hueitan hueitan merged commit 071f735 into hueitan:master Dec 15, 2015
@hueitan
Copy link
Owner

hueitan commented Dec 15, 2015

@lucax88x I have add one more test case for this feature.

@Nazanin1369 API document added in header.

@Nazanin1369
Copy link
Collaborator

Great!
On Dec 14, 2015 8:47 PM, "Huei Tan" [email protected] wrote:

@lucax88x I have add one more test case for this feature.

@Nazanin1369 API document added in header.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants