Fixed no-validation-message condition #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2015
|
Hi @rmngrc We do have the directive to handle this. |
|
Hi @huei90, the directive was never working, that is why I came up with this solution. Anyway, it checks the pressence of the directive and its value so is basically the same. |
|
Thanks @rmngrc for reporting this. |
hueitan
added a commit
that referenced
this pull request
Sep 16, 2015
Completely disabling validation #108 When using $validationProvider.showSuccessMessage and $validationProvider.showErrorMessage, becareful of using no-validation-message
|
Fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple check makes the no-validation-message work. Otherwise, even with no-validation-message="true" always was executing checkValidation and stopping the form of being submitted.