Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix callback reference issue #12

Merged
merged 1 commit into from
May 13, 2014
Merged

Fix callback reference issue #12

merged 1 commit into from
May 13, 2014

Conversation

zack9433
Copy link
Contributor

This error will trigger callback first when validation happen.

@hueitan
Copy link
Owner

hueitan commented May 13, 2014

Hey @zack9433 , thanks for fixing this issue.

But would you mind send me a PR again?

Please also modified the dist angular-validation.js angular-validation.min.js ? (use grunt)

@zack9433
Copy link
Contributor Author

You can check it.

hueitan pushed a commit that referenced this pull request May 13, 2014
Merge pull request #12 from zack9433/master
e3710c8 
Fix callback reference issue
@hueitan hueitan merged commit e3710c8 into hueitan:master May 13, 2014
@hueitan
Copy link
Owner

hueitan commented May 13, 2014

@zack9433

Thanks, keep coming 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zack9433 @hueitan