-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for ignoring properties case for ordering. Related to #78 #196
Conversation
|
This reverts commit 46a70cc.
Tests for properties-alphabetical-order and flat, grouped-flexible, validate-options in properties-order
{ | ||
emptyLineBefore: 'always', | ||
order: 'flexible', | ||
properties: ['top', 'Top'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hudochenkov I need your decision on this. User may provide above properties. In this case they should be informed, that the plugin doesn't work like that.
I added some tests. I haven't added tests in grouped-strict yet. I'd like to know if it's fine. Are there too many tests or not enough etc? |
They are not needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hello :)
There are some issues with #78
I don't know how the plugin should behave with shorthands. I assumed that if user types
Border-width: 1px; Border-top-width: 2px;
they do it on purpose and they expect it to behave just like any other css properties. Do you agree with that?