Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove epidemic week formatting requirements for CDF category values #80

Closed
elray1 opened this issue Jun 8, 2024 · 2 comments · Fixed by #88
Closed

remove epidemic week formatting requirements for CDF category values #80

elray1 opened this issue Jun 8, 2024 · 2 comments · Fixed by #88

Comments

@elray1
Copy link
Contributor

elray1 commented Jun 8, 2024

I just noticed that the schema requires that the CDF values are either numeric or are strings in the format of an epidemic week, e.g. "EW202204". I don't think there's a reason to impose this formatting requirement, though -- one could imagine collecting CDF predictions for an ordinal categorical variable other than epidemic weeks with strings naming the categories that don't match that format.

For example, looking here: https://github.com/Infectious-Disease-Modeling-Hubs/schemas/blob/2e79b13d309168824bcca7ef716ebeb9aa3cda44/v3.0.0/tasks-schema.json#L948-L953

@annakrystalli
Copy link
Member

Quick question, we want min and max removed also right?

"minLength": 8,
"maxLength": 8

@elray1
Copy link
Contributor Author

elray1 commented Jul 24, 2024

yeah, i agree that it makes sense to remove those too

annakrystalli added a commit that referenced this issue Jul 24, 2024
annakrystalli added a commit that referenced this issue Jul 24, 2024
…trictions

Remove restrictive epidemic week formatting requirements for CDF output_type_id values. Resolves #80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants