-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove epidemic week formatting requirements for CDF category values #80
Comments
Quick question, we want min and max removed also right? schemas/v3.0.0/tasks-schema.json Lines 951 to 952 in 2e79b13
|
yeah, i agree that it makes sense to remove those too |
annakrystalli
added a commit
that referenced
this issue
Jul 24, 2024
…ut_type_id values. Resolves #80
annakrystalli
added a commit
that referenced
this issue
Jul 24, 2024
…trictions Remove restrictive epidemic week formatting requirements for CDF output_type_id values. Resolves #80
github-project-automation
bot
moved this from Todo
to Done
in hubverse Development overview
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I just noticed that the schema requires that the CDF values are either numeric or are strings in the format of an epidemic week, e.g. "EW202204". I don't think there's a reason to impose this formatting requirement, though -- one could imagine collecting CDF predictions for an ordinal categorical variable other than epidemic weeks with strings naming the categories that don't match that format.
For example, looking here: https://github.com/Infectious-Disease-Modeling-Hubs/schemas/blob/2e79b13d309168824bcca7ef716ebeb9aa3cda44/v3.0.0/tasks-schema.json#L948-L953
The text was updated successfully, but these errors were encountered: