Fix errors in test model output file #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When correcting s3 class tests, @zkamvar discovered a test that was actually failing when it should in fact be passing. The reason was an error in the test files which included trailing zeros in quantiles. Once that was corrected the test passed.
While it has no actual effect on tests and is only an internal test file, it goes against the best practice we advocate: https://hubverse.io/en/latest/quickstart-hub-admin/tasks-config.html#setting-up-quantile
zkamvar
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #182, when correcting s3 class tests, @zkamvar discovered a test that was actually failing when it should in fact be passing. The reason was an error in a test file which included trailing zeros in quantile output type ids in the test csv file. Once that was corrected the test passes.
This PR resolves the issue #183 by:
NAs but that is equally valid representation of missing values so I've left it.task.jsonconfig file to remove trailing zeros from quantile output type id value specification and conform to the best practice we advocate https://hubverse.io/en/latest/quickstart-hub-admin/tasks-config.html#setting-up-quantile@zkamvar I branched off from and made this PR into your test correction PR so that I could remove the test skip. I can confirm the test passes locally and if you were happy to merge into your PR, you could double check the tests pass on there before merging into
main. If not let me know when #182 is merged and I'll synch this PR with main and redirect it