Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

98/ Subset expanded grid of valid values by output type #107

Merged
merged 40 commits into from
Aug 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
70fcdc2
Add argument to create output type subsets of valid value grids
annakrystalli Aug 8, 2024
4468d1b
streamline subsetting of round_config
annakrystalli Aug 8, 2024
6db473c
Document
annakrystalli Aug 8, 2024
3ef92ff
Move config_tasks round utilities to separate file
annakrystalli Aug 9, 2024
21d2f85
Add arg to specify derived task-ids to ignore. Relates to #93
annakrystalli Aug 9, 2024
2aa70e9
optimise check_tbl_values by output_type batching & ignoring derived …
annakrystalli Aug 9, 2024
93a4bf2
Ignore derived task-ids in check_tbl_values_required
annakrystalli Aug 12, 2024
76c8254
Add some comments in test
annakrystalli Aug 13, 2024
27ef0e6
Remove deprecated TODO note
annakrystalli Aug 12, 2024
cead075
delete dplyr loading
annakrystalli Aug 13, 2024
c9ea7e0
Don't lint helper
annakrystalli Aug 13, 2024
a6d0981
style to fix lint issues
annakrystalli Aug 13, 2024
8815afc
Fix lint issues
annakrystalli Aug 13, 2024
2a2e948
add match_tbl_to_model_task function
annakrystalli Aug 14, 2024
2bc332c
refactor check_tbl_value_col to work on smaller subsets of data
annakrystalli Aug 14, 2024
7fe78b4
propagate output subsetting and derived_task_ids arg to spl checks
annakrystalli Aug 14, 2024
1b003f2
propagate output subsetting and derived_task_ids arg to higher level …
annakrystalli Aug 14, 2024
0686ff4
Fix error_tbl bug by using original tbl rowids
annakrystalli Aug 14, 2024
df0815e
remove unused functions
annakrystalli Aug 14, 2024
4f18bca
Fix linter issues
annakrystalli Aug 14, 2024
809a340
Bump version
annakrystalli Aug 14, 2024
451b7a2
Add more detail to NEWS
annakrystalli Aug 14, 2024
d204dae
Merge branch '98/subset-grid-by-out-type' into 93/add-derived-tid-arg
annakrystalli Aug 14, 2024
c6c5423
Add missing early return.
annakrystalli Aug 15, 2024
70afb1d
Make ignored derived task id message clearer
annakrystalli Aug 15, 2024
74ad9a4
rerun snapshot
annakrystalli Aug 15, 2024
1811ede
remove superfluous check
annakrystalli Aug 15, 2024
2cce180
Merge pull request #108 from hubverse-org/93/add-derived-tid-arg
annakrystalli Aug 15, 2024
4a45645
merge earlier PRs
annakrystalli Aug 15, 2024
edbf939
Throw error if invalid output_type supplied instead of ignoring.
annakrystalli Aug 15, 2024
28715b3
add output_types and derived_task_ids arguments to submission_tmpl
annakrystalli Aug 15, 2024
8ec8261
Add note on derived task IDs in pkgdown docs
annakrystalli Aug 15, 2024
2163c5c
Add fn comments
annakrystalli Aug 16, 2024
23b4655
add tests that explicitly check derived_task_ids are ignored
annakrystalli Aug 16, 2024
7b8a953
Update R/check_tbl_values.R
annakrystalli Aug 16, 2024
29c3909
Merge pull request #109 from hubverse-org/93/3-batch-value-validation
annakrystalli Aug 16, 2024
50a1cf9
Merge branch 'main' into 98/subset-grid-by-out-type
annakrystalli Aug 16, 2024
d3af4a7
Fix merge errors
annakrystalli Aug 16, 2024
3359fd9
Use inst example hub, not testdata one in submission_tmpl examples
annakrystalli Aug 16, 2024
bc18984
Add note in NEWS re submission_tmpl args. Correct formating.
annakrystalli Aug 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove superfluous check
annakrystalli committed Aug 15, 2024
commit 1811ede790f8877f9f1d57082415b7b5d37108eb
2 changes: 1 addition & 1 deletion R/expand_model_out_grid.R
Original file line number Diff line number Diff line change
@@ -380,7 +380,7 @@ null_taskids_to_na <- function(model_task) {

# Set derived task_ids to all NULL values.
derived_taskids_to_na <- function(model_task, derived_task_ids) {
if (!is.null(derived_task_ids) || length(derived_task_ids) > 0L) {
if (!is.null(derived_task_ids)) {
purrr::modify_at(
model_task,
.at = derived_task_ids,