Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ascending CDF values with numeric output_type_id cast as character #105

Merged
merged 29 commits into from
Jan 8, 2025
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
98c4252
add support for ascen cdf values w/num out_type_id
zkamvar Aug 12, 2024
3ed727d
dang lintr what I ever do to you?
zkamvar Aug 12, 2024
a7a4be9
Update tests/testthat/test-check_tbl_value_col_ascending.R
zkamvar Aug 12, 2024
8421214
fix ordering to be based on hub config
zkamvar Aug 13, 2024
808e6e6
add arguments in validate_model_data
zkamvar Aug 13, 2024
f551702
update, man
zkamvar Aug 13, 2024
dea1cc8
appease the linter
zkamvar Aug 13, 2024
d3d2937
fix skipped test
zkamvar Aug 13, 2024
defd517
remove :skull: code
zkamvar Aug 13, 2024
c82014d
avoid message in test
zkamvar Nov 7, 2024
cf92b6a
clean up internal doc
zkamvar Nov 7, 2024
c64bf73
appeas lintr
zkamvar Nov 7, 2024
8e69bb8
fix test assumptions; add failure test check
zkamvar Jan 3, 2025
f52f619
move early exit; only create cdf/quantile grid
zkamvar Jan 3, 2025
f3f04cf
oops
zkamvar Jan 3, 2025
d2517dd
add failing test for check of ascending columns
elray1 Jan 7, 2025
c0c356a
simplify order_output_type_ids; clarify object names
zkamvar Jan 7, 2025
95d47af
Update tests/testthat/test-check_tbl_value_col_ascending.R
elray1 Jan 7, 2025
c8b9e67
read in test data using read_model_out_file
zkamvar Jan 7, 2025
b76cf0f
Merge pull request #188 from hubverse-org/elr/ascending_check_test_case
zkamvar Jan 7, 2025
a3eb124
read in model output using hubvalidation mechanism
zkamvar Jan 7, 2025
3471e4d
add MWE for internal function
zkamvar Jan 7, 2025
7b43e64
update grouping for sorting; do not coerce ref to char
zkamvar Jan 7, 2025
3148f40
removed modification of target in test
zkamvar Jan 7, 2025
afa20db
add TODO note
zkamvar Jan 7, 2025
98b022e
appease linter
zkamvar Jan 7, 2025
93a5eb7
clean up expectations
zkamvar Jan 7, 2025
1591351
add internal doc
zkamvar Jan 7, 2025
ca6eea7
add NEWS item
zkamvar Jan 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
appeas lintr
zkamvar committed Jan 3, 2025
commit c64bf73a7ccaac704e42beb0c613b992db543a50
2 changes: 1 addition & 1 deletion R/check_tbl_value_col_ascending.R
Original file line number Diff line number Diff line change
@@ -96,7 +96,7 @@ split_cdf_quantile <- function(tbl) {
# Order the output type ids in the order of the config
#
# This extracts the output_type_id from the config-generated table for the
# given types and creates a lookup table that has the types in the right order.
# given types and creates a lookup table that has the types in the right order.
#
# The data from `tbl` is then joined into the lookup table (after being coerced
# to character), which sorts `tbl` in the order of the lookup table.