Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubValidations quantile check error if the quantiles are not ordered #70

Closed
M-7th opened this issue Jan 12, 2024 · 2 comments · Fixed by #67
Closed

hubValidations quantile check error if the quantiles are not ordered #70

M-7th opened this issue Jan 12, 2024 · 2 comments · Fixed by #67

Comments

@M-7th
Copy link

M-7th commented Jan 12, 2024

Working on the https://respicast.ecdc.europa.eu/ platform we noticed a feature of the validations package that modelers don't find desirable.
When checking that the values for quantiles are decreasing, the validations give the following error if the quantiles are not ordered in the input file:
! 2024-01-10-ISI-FluABCaster.csv: Values in 'value' column are not non-decreasing as output_type_ids increase for all unique task ID value/output type combinations of quantile or cdf output types. See error_tbl attribute for details.

Once the quantiles are ordered the validation step is passed without errors:
✔ 2024-01-10-ISI-FluABCaster.csv: Values in 'value' column are non-decreasing as output_type_ids increase for all unique task ID value/output type combinations of quantile or cdf output types.

Is there a rationale for this? Would it be possible to perform the check without requiring that the records are written in the file ordered by quantile?

Attached you can find the ordered and unordered csv files used to reproduce this issue.

Many thanks for your kind assistance
Paolo

2024-01-10-ISI-FluABCaster_not_ordered.csv
2024-01-10-ISI-FluABCaster_ordered.csv

@annakrystalli
Copy link
Member

annakrystalli commented Jan 12, 2024

Thanks for reporting @M-7th !

This was indeed a bug and is now fixed in eac3036 as part of #67 . Should be merged in soon !

@M-7th
Copy link
Author

M-7th commented Jan 12, 2024

Many thanks @annakrystalli for your support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants