bump to dev; fix tests for hubUtils 0.2.0 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting errors when I ran tests/testthat/test-hub-connection.R with `devtools::test_active_file()` in a single session. This was caused by the tempdir not being cleaned up after the test was finished.
annakrystalli
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the snapshot tests to reflect the fact that all config files now have the
configclass and that the URLs are automatically updated with a message.It also uses
withr::local_tempdir()instead oftempdir()so that the directory could be gracefully cleaned up after the test.I had forgotten to open a dev version bumping PR, so that is included here.
withr::local_tempdir()for tests