Middleware execute returns a promise (v3) #1371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 22, 2017 15:24
Builds in node 0.10.x were failing due to lack of promise support 1339
Allows rejecting if middleware throws related hubotio#1339
# Conflicts: # src/middleware.coffee # src/response.coffee # src/robot.coffee # test/middleware_test.coffee Migrated promise features from removed coffee into js
es6 promise was a v2 required for earlier node versions that are no longer supported
This was referenced Aug 2, 2019
Closed
Dark403969
approved these changes
Jun 22, 2021
|
We should probably use async/await instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated my PR #1370 with v3 changes, including refactoring async middleware tests in js (from coffeescript) and I added some tests for response class, showing variations using / not-using returned promise.
There were no tests for the response class previous to this, so I'm pretty positive I haven't done it the best way, but I've at least provided a baseline for the team to review. Please give me feedback for how I can improve those tests.