Added Schedules restrictions with command who-s-on-call #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldios
changed the title
|
We would want to update the README file to document the new setting. |
|
@stephenyeargin README.md updated: 👍 |
a-palchikov
reviewed
Nov 23, 2018
src/scripts/pagerduty.coffee
Outdated
| renderSchedule = (s, cb) -> | ||
| withCurrentOncall msg, s, (username, schedule) -> | ||
| if (username) | ||
| messages.push("* #{username} is on call for #{schedule.name} - #{schedule.html_url}") | ||
| if !allowed_schedules or (allowed_schedules and schedule.id in allowed_schedules) |
There was a problem hiding this comment.
I think this could simpler:
if !allowed_schedules or schedule.id in allowed_schedulesAlso, unless process.env.HUBOT_PAGERDUTY_SCHEDULES is always defined, reading it can yield an undefined value and split is only defined for strings (iirc), so I would rewrite this as:
allowed_schedules = pagerDutySchedules?.split(",")Depending on whether it is desired to treat empty pagerDutySchedules as unspecified:
if !pagerDutySchedules?.length or schedule.id in allowed_scheduleswhich should probably be mentioned in the documentation as well.
There was a problem hiding this comment.
@a-palchikov is that okay now?
stephenyeargin
approved these changes
Nov 25, 2018
|
Released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added PagerDuty rescrition option (basic feature) to restrict the
who's on callcommand.Re: #109 (comment)