Problem: These deleted functions are defined lower in this function. … #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This will cause confusion if/when a developer later tries to alter the behavior of one of these functions. Solution: Delete the unused definitions.
| userEmail = (user) -> | ||
| user.pagerdutyEmail || user.email_address || user.profile?.email || process.env.HUBOT_PAGERDUTY_TEST_EMAIL | ||
|
|
||
| campfireUserToPagerDutyUser = (msg, user, required, cb) -> |
There was a problem hiding this comment.
There appears to still be calls to this method in particular on L758.
There was a problem hiding this comment.
There was a problem hiding this comment.
This PR is deleting duplicate definitions. It does not delete any function definition that hasn't been re-defined below it.
stephenyeargin
approved these changes
Nov 17, 2018
|
Released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… This will cause confusion if/when a developer later tries to alter the behavior of one of these functions.
Solution: Delete the unused definitions.